(core) - Make DocumentNode serialization idempotent #1509
Conversation
🦋 Changeset detectedLatest commit: d8c59a9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kitten
changed the title
There was a problem hiding this comment.
This is a really awesome catch! I didn't realise that this would introduce an inconsistency in GraphQL Code Generator output since I didn't consider that loc mane left out at times depending on its mode, which is entirely probable in other use cases too. Also nice idea to fix it this way 🔥
The only thing that's left is that some snapshots need updating now, however a yarn test -u run should fix that. The changeset also has a suggestion by me to make it a little more descriptive
Co-authored-by: Phil Pluckthun <[email protected]>
|
@kitten Suggestion for changeset applied and Jest snapshots updated :) |
Summary
Fixes #1508
Set of changes
This makes DocumentNode serialization idempotent.
In other words, this makes it so we get the same serial representation (and therefore hash key) for a DocumentNode each time it is computed.