(core) - Remove deprecated operationName property from Operations #1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: adba183 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kitten
force-pushed
the
chore/remove-deprecated-operationname
branch
from
382fcd1 to
adba183
Compare
JoviDeCroock
approved these changes
Feb 10, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1354
Summary
In #1045 we've deprecated the
Operation.operationNameproperty as specced out in #1005.I believe we're now ready to get rid of it as all exchanges that are maintained by us have been migrated over and nothing stops us from switching over as we've given sufficient time for people to adopt this change. The warning is still spurious in
@urql/devtoolsand may confuse new users, so the sooner we can remove it the better.Set of changes
operationNameand associated warning utilities@urql/coreversion