(graphcache) - Enable more cache.keyOfEntity parent cases and deprecate cache.resolveFieldByKey #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d23dc0f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kitten
changed the title
JoviDeCroock
approved these changes
Dec 10, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #1207
Follow up to #1208
Summary
This enables a case that the previous patch was meant to enable, the usage of
cache.resolve(parent, ...)whereparentdoes not have a__typenamefield (or other keyable field) set yet.This also deprecated
cache.resolveFieldByKeysince I coincidentally noticed that it's not necessary anymore.Set of changes
ctx.parentcheck incache.keyOfEntitycache.keyOfEntityslightlycache.resolveFieldByKeyin favour ofcache.resolveand update docscache.resolveFieldByKeyin extras sources