Is this a memory leak in cacheExchange?

[trcoffman]

https://github.com/FormidableLabs/urql/blob/main/exchanges/graphcache/src/cacheExchange.ts#L246-L257

If you look here, it seems to me like after hydration is complete, all other operations that come through will end up getting buffered forever. the hydration fromPromise will never emit again so the buffer will grow and grow. Keeping references to objects that will never ever be used again seems to me like a memory leak.

It seems to me like there should be a takeUntil to prevent this, like this:

    const inputOps$ = hydration
      ? share(
          merge([
            pipe(
              sharedOps$,
              takeUntil(fromPromise(hydration)),
              buffer(fromPromise(hydration)),
              mergeMap(fromArray)
            ),
            pipe(sharedOps$, skipUntil(fromPromise(hydration))),
          ])
        )
      : sharedOps$;

Does wonka's share somehow prevent this? I am just learning this stuff so perhaps I'm mistaken on how this stuff really works.

[trcoffman]

Nevermind, I was looking at wonka code and it looks like fromPromise will emit an End that will turn off the buffer. Nothing to see here, no memory leak!