Skip to content
This repository has been archived by the owner on Jul 6, 2020. It is now read-only.

(fix) - respect alternative rootkeys in query #87

Merged
merged 1 commit into from
Sep 24, 2019

Conversation

JoviDeCroock
Copy link

@JoviDeCroock JoviDeCroock commented Sep 24, 2019

Very odd but this test keeps on failing locally but on github actions, it would be odd if my PR would touch that test but yes... (See EDIT)

 FAIL  src/test-utils/examples-1.test.ts (5.087s)
  ● correctly resolves optimistic updates on Relay schemas

    expect(received).not.toBe(expected) // Object.is equality

    Expected: not null

      379 | 
      380 |   expect(queryRes.partial).toBe(false);
    > 381 |   expect(queryRes.data).not.toBe(null);
          |                             ^
      382 | });
      383 | 

      at Object.<anonymous>.it (src/test-utils/examples-1.test.ts:381:29)

EDIT: I should really make a personal pre-test where it does yarn....

@JoviDeCroock JoviDeCroock requested a review from kitten September 24, 2019 09:02
@@ -79,7 +79,7 @@ export const read = (

let data = input || Object.create(null);
data =
rootKey !== 'Query'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👏

@JoviDeCroock JoviDeCroock merged commit 9a51cbb into master Sep 24, 2019
@JoviDeCroock JoviDeCroock deleted the fix/alternativeQueryRootkeyIssue branch September 24, 2019 17:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants