Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SubtractPipe and AddPipe #78

Closed
wants to merge 8 commits into from
Closed

Added SubtractPipe and AddPipe #78

wants to merge 8 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 29, 2016

I added the functions for SubtractPipe and AddPipe. These are used as:
{{ mydate | amAdd : '2' : 'hours' }}
{{ mydate | amSubtract : '2' : 'hours' }}

@pisix
Copy link

pisix commented Oct 5, 2016

@urish please can you merge this PR ?

@urish
Copy link
Owner

urish commented Oct 5, 2016

Eventually yes, but first of all I want to make sure that the existing project works with all setups (Ionic, rollup, protractor, AMD) and release 1.0.0. You can see #90, #91, #89 , #87, #85 , #82, #80 as examples for such issues

@urish
Copy link
Owner

urish commented Dec 10, 2016

@dustin486 Hi, can you please update the PR to align the file names with angular2 style guide convention?

i.e. use add.pipe.ts instead of AddPipe.ts, etc.

I would love to see this feature as part of the upcoming 1.1.0 release :)

Thanks!

@ghost
Copy link
Author

ghost commented Dec 10, 2016

@urish Sure. I am at work until later tonight, but will do this tomorrow.

@urish
Copy link
Owner

urish commented Dec 10, 2016

Much appreciated!

@urish
Copy link
Owner

urish commented Dec 13, 2016

Ping

@ghost
Copy link
Author

ghost commented Dec 14, 2016

@urish Sorry, I've been sick for a few days, still am. I don't know what happened to this one, but I messed it up merging my local copy with your version. I just created another fork, updated mine, and opened a new PR: #113

This one can be closed. Sorry about the confusion.

@urish
Copy link
Owner

urish commented Dec 14, 2016

I hope that you feel better now :-)

I will take a look at #113 soon!

@urish urish closed this Dec 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants