Skip to content
This repository was archived by the owner on Mar 29, 2022. It is now read-only.

[Fixes #77] CLI data parameter #78

Merged
merged 5 commits into from
Feb 6, 2017
Merged

Conversation

mediavrog
Copy link
Contributor

@mediavrog mediavrog commented Feb 3, 2017

No description provided.

@urish
Copy link
Owner

urish commented Feb 3, 2017

Thanks for the PR!

Some notes:

  1. Let's have separate options for reading from a file vs supplying the data on the command line.
  2. Please document the new options in the README file
  3. Please fix the eslint issues to make the build past

@mediavrog
Copy link
Contributor Author

Hi @urish

Thanks for the reply. I will split the options and fix the linting issues.

As for readme, I though as you have the note

For more information, run:

	node_modules/.bin/firebase-server -h

in the readme and other options are also not documented, the cli should document itself. Let me know if updating the readme is still necessary

@mediavrog
Copy link
Contributor Author

One question to @urish :

Would you prefer the command to fail if a given file or JSON is invalid, or just start anyway with {} as data?

@urish
Copy link
Owner

urish commented Feb 6, 2017

It should fail in this case. thx!

@mediavrog
Copy link
Contributor Author

@urish Made the changes. If you're good with it, please squash-merge. Cheers

@urish
Copy link
Owner

urish commented Feb 6, 2017

Looks good - one last thing, can you please document the new options in the README file?

@coveralls
Copy link

coveralls commented Feb 6, 2017

Coverage Status

Coverage remained the same at 97.306% when pulling 9a69cd0 on en-japan-air:77-data-param into 7d2fa2b on urish:master.

@urish urish merged commit 8b23801 into urish:master Feb 6, 2017
@urish
Copy link
Owner

urish commented Feb 6, 2017

Released as 0.9.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants