Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Никишина Маргарита #59

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Никишина Маргарита #59

wants to merge 3 commits into from

Conversation

MargaritaNik
Copy link

No description provided.

@honest-hrundel
Copy link

🍅 Пройдено тестов 4 из 5

@honest-hrundel
Copy link

🍅 Пройдено тестов 4 из 5

@honest-hrundel
Copy link

🍏 Пройдено тестов 5 из 5

ya-woodcutter
ya-woodcutter requested changes Jan 9, 2019
View reviewed changes
Copy link

@ya-woodcutter ya-woodcutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В целом неплохо, но копипасту лучше убрать из классов DesktopView и MobileView

src/views/mobile.ts
if (observable instanceof WeatherState) {
this.weathers = observable.getMeasurements().slice(-1);
}
this.render();
}

public render() {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Методы render и update очень похожи на реализацию из DesktopView... может реализовать их однажды, но наследоваться с разными параметрами?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ya-woodcutter ya-woodcutter ya-woodcutter requested changes

Assignees

@ya-woodcutter ya-woodcutter

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MargaritaNik @honest-hrundel @ya-woodcutter