-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Денисов Андрей #127
base: master
Are you sure you want to change the base?
Денисов Андрей #127
Conversation
🍏 Пройден линтинг и базовые тесты |
background-color: #6698ff; | ||
} | ||
|
||
aside |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Можно объединить в один селектор с предыдущим
border-top: 1px solid rgb(0, 0, 0); | ||
} | ||
|
||
article:nth-child(4), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Можно проще, используя odd
или even
@@ -12,7 +12,11 @@ <h1 class="global-heading"> </h1> | |||
|
|||
<main class="global-results"> | |||
<style> | |||
/* your styles here */ | |||
div:nth-of-type(2), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Прозрачные картинки от непрозрачных отличаются атрибутом alt
, можно это использовать
color: #ffb366; | ||
} | ||
|
||
[href^='https']:hover |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
не обязательно тут проверять на https, у псевдоссылок вообще нет атрибута href
. Можно использовать например :not
для них
div:nth-of-type(1), | ||
:nth-of-type(3), | ||
:nth-of-type(7), | ||
:nth-of-type(9) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Так работает, но можно было посмотреть внимательней на html ) Оранжевые и желтые квадраты отличаются там
/* your styles here */ | ||
div:nth-child(1) > div:nth-child(1), | ||
div:nth-child(5) > div:nth-child(1), | ||
div:nth-child(9) > div:nth-child(1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Здесь тоже можно было посмотреть на html, и придумать более простой селектор: div:only-of-type
|
||
#id1 | ||
{ | ||
background-color: #ffb366 !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Зачем везде !important
? Его нужно использовать только в крайнем случае, когда других способов нет. Здесь хватило бы одного important
в нужном селекторе
opacity: .5; | ||
} | ||
|
||
div:hover |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Работает не совсем так. При наведении на один блок все остальные блоки должны становиться еще более прозрачными
Посмотреть решение