Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ильющенко Анастасия #116

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Kaprican
Copy link

@Kaprican Kaprican commented Oct 18, 2018

@honest-hrundel
Copy link

🍅 Не пройден линтинг или базовые тесты

@honest-hrundel
Copy link

🍅 Не пройден линтинг или базовые тесты

@honest-hrundel
Copy link

🍏 Пройден линтинг и базовые тесты

Copy link

@nex2hex nex2hex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍅
мелочь

@@ -12,7 +12,15 @@ <h1 class="global-heading">&nbsp;</h1>

<main class="global-results">
<style>
/* your styles here */
[href]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

можно указать тэг ссылки, чтобы селектор искал только ссылки

@@ -12,7 +12,10 @@ <h1 class="global-heading">&nbsp;</h1>

<main class="global-results">
<style>
/* your styles here */
a[target='_blank']
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

нужно выделить внешние ссылки, а не те, которые открываются в новом окне

@@ -12,7 +12,16 @@ <h1 class="global-heading">&nbsp;</h1>

<main class="global-results">
<style>
/* your styles here */
div
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

нужно решить без использования nth

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А как это делается без nth-child?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

попробуй с помощью :only-of-type

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Но там же они все divы -_-"

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

обрати внимание на переносы строк

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants