-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go.mod: Require go1.22 #2026
go.mod: Require go1.22 #2026
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't be better to just copy the layout from standard library.
I mean, if the reason for upgrading the version is to just use that time template (time.TimeOnly). you can simply copy it (or write it manually).
I'm not against upgrading to higher versions, it's just need to be for a good reason.
Depends on what you want to support, given that this is a major version bump, the CI only checks for currently 1.22, 1.23 and 1.18 is EOL since almost 2 years (https://endoflife.date/go), I would recommend to probably even bump it to v1.22 (even if you don't need it that high). |
Amm, Alright, In that case, considering the stability of the language. I agree with you that we can bump to Thanks @mrueg. ❤️ |
Do you want me to update the PR to go1.22? |
+1 from me :) |
Done :) |
e24eb06
to
cb586d8
Compare
What type of PR is this?
What this PR does / why we need it:
Require at least go 1.22
golang/go#52746
Which issue(s) this PR fixes:
Fixes #2024
Release Notes