Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: Require go1.22 #2026

Merged
merged 1 commit into from
Dec 3, 2024
Merged

go.mod: Require go1.22 #2026

merged 1 commit into from
Dec 3, 2024

Conversation

mrueg
Copy link
Contributor

@mrueg mrueg commented Dec 3, 2024

What type of PR is this?

  • feature

What this PR does / why we need it:

Require at least go 1.22
golang/go#52746

Which issue(s) this PR fixes:

Fixes #2024

Release Notes

Raise minimum go version to 1.22

@mrueg mrueg requested a review from a team as a code owner December 3, 2024 09:58
Copy link
Member

@yassinebenaid yassinebenaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't be better to just copy the layout from standard library.

I mean, if the reason for upgrading the version is to just use that time template (time.TimeOnly). you can simply copy it (or write it manually).

I'm not against upgrading to higher versions, it's just need to be for a good reason.

@mrueg
Copy link
Contributor Author

mrueg commented Dec 3, 2024

Depends on what you want to support, given that this is a major version bump, the CI only checks for currently 1.22, 1.23 and 1.18 is EOL since almost 2 years (https://endoflife.date/go), I would recommend to probably even bump it to v1.22 (even if you don't need it that high).

@yassinebenaid
Copy link
Member

Amm, Alright, In that case, considering the stability of the language. I agree with you that we can bump togo 1.22 .

Thanks @mrueg. ❤️

@mrueg
Copy link
Contributor Author

mrueg commented Dec 3, 2024

Do you want me to update the PR to go1.22?

@bartekpacia
Copy link
Member

Do you want me to update the PR to go1.22?

+1 from me :)

@mrueg
Copy link
Contributor Author

mrueg commented Dec 3, 2024

Do you want me to update the PR to go1.22?

+1 from me :)

Done :)

@mrueg mrueg changed the title go.mod: Require go1.20 go.mod: Require go1.22 Dec 3, 2024
@bartekpacia bartekpacia merged commit 35945b7 into urfave:main Dec 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v3 error: flag_timestamp.go:92:44: undefined: time.TimeOnly
6 participants