Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add v3 docs links #2022

Merged
merged 1 commit into from
Nov 30, 2024
Merged

Docs: Add v3 docs links #2022

merged 1 commit into from
Nov 30, 2024

Conversation

dearchap
Copy link
Contributor

What type of PR is this?

(REQUIRED)

  • documentation

What this PR does / why we need it:

(REQUIRED)

Rollout v3 docs.

Which issue(s) this PR fixes:

(REQUIRED)

Special notes for your reviewer:

(fill-in or delete this section)

Testing

(fill-in or delete this section)

Release Notes

(REQUIRED)

Add v3 docs links

@dearchap dearchap requested a review from a team as a code owner November 30, 2024 20:26
Copy link
Member

@meatballhat meatballhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩

@dearchap dearchap merged commit 606c89a into urfave:main Nov 30, 2024
11 checks passed
- Subcommands Categories: v3/examples/subcommands-categories.md
- Exit Codes: v3/examples/exit-codes.md
- Combining Short Options: v3/examples/combining-short-options.md
- Bash Completions: v3/examples/bash-completions.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step along with the documentation file are named : Bash completion. However, they contain content regarding all of bash, zsh and powershell completion.

Wouldn't be good to rename them as : Shell Completion ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes will do. Thanks for pointing it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants