Make it possible to source the Zsh autocomplete script
#1896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meatballhat
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Heck yeah, shfmt! I would love to see some shfmt and shellcheck in CI at some point 🤩
Thank you, @bartekpacia 🤘🏼
|
Those are on my list :) |
bartekpacia
force-pushed
the
fix/autocomplete
branch
from
ad2f469 to
0b61790
Compare
|
@bartekpacia Please merge whenever you're ready 😁 And we've got auto-merge set up here, which you're welcome to turn on for any PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
This PR updates the default Zsh autcompletion script so it can be
sourced. This makes debugging/testing autocompletion easier, because there's no need to copy this file tozsh/site-functionsdir and rename it.I first described this problem in #1874
I also formatted this file with
shfmt.Which issue(s) this PR fixes:
Related to #1874.
I'm not sure if the same problem occurs in Bash. I'll check when I have more free time and possibly fix it in another PR.
Special notes for your reviewer:
None.
Testing
Tested locally.
I use this version of the
zsh_autocompletescript in my own CLI programs, and it works as intended. Example:bartekpacia/emu.Release Notes