Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix:(issue_1814) Fix completions for subcommands #1824

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

dearchap
Copy link
Contributor

What type of PR is this?

(REQUIRED)

  • bug

What this PR does / why we need it:

(REQUIRED)

Which issue(s) this PR fixes:

(REQUIRED)

Fixes #1814

Special notes for your reviewer:

(fill-in or delete this section)

Testing

(fill-in or delete this section)

Add new test case

go test -run=TestCompletionSubcommand

Release Notes

(REQUIRED)


@dearchap dearchap requested a review from a team as a code owner November 26, 2023 15:08
Copy link

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.

Note:

Frogbot also supports Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning. This features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.


Copy link
Member

@meatballhat meatballhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 😍

@dearchap dearchap merged commit 1f0e15c into urfave:main Nov 27, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug report: shell completion doesn't work with sub-commands v3-alpha4
2 participants