Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Porting to v3 #1510

Merged
merged 98 commits into from
Oct 6, 2022
Merged

Porting to v3 #1510

merged 98 commits into from
Oct 6, 2022

Conversation

meatballhat
Copy link
Member

@meatballhat meatballhat commented Oct 1, 2022 •
edited
Loading

What type of PR is this?

  • maintenance

What this PR does / why we need it:

Forward-porting changes from the v2 series so that v3 does not introduce regressions.

Which issue(s) this PR fixes:

Closes #1509

Special notes for your reviewer:

PRs ported from the v2 series:

dearchap and others added 5 commits October 1, 2022 19:46
@dearchap @meatballhat
issue_62: Make slice options more posix like
bc99b58
@dearchap @meatballhat
Changes from code review
45a1375
@meatballhat
Move genflags tool to cmd/ and pin to previous release
2ca9143 
to alleviate problems caused by the circular dependency of using the
same code as a library that is potentially being generated to adhere to
a different API.
@meatballhat
Tidy up top-level go.mod
d8de3b5
@meatballhat
Add missing go.sum entries for go 1.16.x
a5313eb
@meatballhat meatballhat changed the title V3 porting Porting to v3 Oct 2, 2022
meatballhat and others added 20 commits October 2, 2022 10:26
@meatballhat
Use goimports as formatting standard
cbc7f1a 
given some disagreement with gofmt that seems to have shown up in 1.19
@meatballhat
Shift supported go versions
76bb9f1 
and approve word-wrapping changes to godoc
@hay-kot @meatballhat
split v1 docs into individual pages
1ae70fc
@hay-kot @meatballhat
breakup v2 documentation
edaf885
@hay-kot @meatballhat
update sidebar configuration
18f8e6d
@hay-kot @meatballhat
add tags plugin
7cfafe8
@hay-kot @meatballhat
add tags and boost for pages
8036eac
@hay-kot @meatballhat
wip: add --walk flag to gfrun to accept directory
d217a5a
@hay-kot @meatballhat
pass in correct root
87f003f
@hay-kot @meatballhat
rename filename to dirPath
2b1a8ca
@dearchap @meatballhat
Fix:(issue_1094) Dont execute Before/After handlers during shell comp…
42d8058 
…letion
@dearchap @meatballhat
Rename function
42eb492
@dearchap @meatballhat
Fix:(issue_1455) Allow bool flags from input altsrc
78dac9c
@dearchap @meatballhat
Remove debug println
3c6588c
@dearchap @meatballhat
Revert godoc changes
f515798
@ccremer @meatballhat
Add configurable Base to int, uint and uint64 flags
382386a 
This allows users to configure the basis for integer parsing.
@Gerrard-YNWA @meatballhat
fix: allow required flag with one character
9de6fa4
@Gerrard-YNWA @meatballhat
fix: update test case
9092325
@james-prysm @meatballhat
adding in boolean alias support
e0db267
@james-prysm @meatballhat
adding string alias and test
50bbb4a
meatballhat and others added 25 commits October 3, 2022 07:49
@meatballhat
Set codecov status thresholds to 5%
0658d61 
and rename file to be less dotty
@dearchap @meatballhat
Fix: dont generate pointer for dest for Generic flag
e13c16b
@dearchap @meatballhat
Fix: Help name consistency among app/commands and subcommands
8e3fa06
@meatballhat
Move more functionality into internal/build/build.go
8cc0a9c 
and use make targets in CI, pass flag spec YAML through yq

includes result of running `make v2approve`
@meatballhat
Run make target after the Makefile is available
d9d960a
@meatballhat
Use windows compatible path append
2bec081
@meatballhat
Only run make v2diff on go 1.19.x + ubuntu-latest
0593812
@meatballhat
Replace a few more custom make targets
d6c9f6a
@meatballhat
Use correct env var for global flags
9ed5a09
@meatballhat
Accept the MKDOCS_REMOTE_GITHUB_TOKEN var as intended
1c3ebfa
@dearchap @meatballhat
Fix:(issue_1197) Set destination field from altsrc for slice flags
d2acd0e
@dearchap @meatballhat
Add unit tests
e9e87f6
@meatballhat
fix: Context.Set no such flag
a2c3729
@xwjdsh @meatballhat
feat: flag action
e2e14ec
@xwjdsh @meatballhat
Add more tests about flag-level action
f9ceca5
@xwjdsh @meatballhat
Rebase main, update flag-spec.yaml to add Action field
d213683
@xwjdsh @meatballhat
make v2approve
1e30f50
@xwjdsh @meatballhat
Add more test cases
126297a
@dearchap @meatballhat
Fix:(issue_557) Change app help name
4c637d8
@dearchap @meatballhat
Fix:(issue_557) Make help output consistent between different invocat…
57ff098 
…ions
@dearchap @meatballhat
Remove un-needed func
c2ecb44
@dearchap @meatballhat
Remove un-needed func
8ef92d2
@meatballhat
Remove nonexistent phony targets
5db9db6 
so that running `make` or `make all` only runs targets that exist.
@meatballhat
Post-porting fixes for v3
f8faf77
@meatballhat
Point docs tests at v3
a851a77
@meatballhat meatballhat marked this pull request as ready for review October 3, 2022 14:17
@meatballhat meatballhat requested a review from a team as a code owner October 3, 2022 14:17
@dearchap dearchap merged commit 9166808 into v3-dev-main Oct 6, 2022
@dearchap dearchap deleted the v3-porting branch October 6, 2022 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dearchap dearchap dearchap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.