Merge pull request #1815 from Juneezee/refactor/redundant-nil-check

Remove redundant nil check in `LocalFlagNames`
urfave · Oct 11, 2023 · e8abd76 · e8abd76
2 parents a8de551 + 3da6a64
commit e8abd76
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/command.go b/command.go
@@ -922,11 +922,9 @@ func (cmd *Command) LocalFlagNames() []string {
 	cmd.flagSet.Visit(makeFlagNameVisitor(&names))
 
 	// Check the flags which have been set via env or file
-	if cmd.Flags != nil {
-		for _, f := range cmd.Flags {
-			if f.IsSet() {
-				names = append(names, f.Names()...)
-			}
+	for _, f := range cmd.Flags {
+		if f.IsSet() {
+			names = append(names, f.Names()...)
 		}
 	}