Merge pull request #1378 from dearchap/issue_1334

Feature:(Issue 1334) Add support for uint64slices
urfave · Sep 10, 2022 · d62ac9c · d62ac9c
2 parents 6ccecf2 + d0fff2e
commit d62ac9c
Show file tree

Hide file tree

Showing 9 changed files with 1,285 additions and 13 deletions.
diff --git a/.github/.codecov.yml b/.github/.codecov.yml
@@ -1 +1,3 @@
 comment: false
+coverage:
+  threshold: 5%
diff --git a/altsrc/flag_test.go b/altsrc/flag_test.go
@@ -40,7 +40,7 @@ func (ris *racyInputSource) isSet(name string) bool {
 func TestGenericApplyInputSourceValue_Alias(t *testing.T) {
 	v := &Parser{"abc", "def"}
 	tis := testApplyInputSource{
-		Flag:     NewGenericFlag(&cli.GenericFlag{Name: "test",  Aliases: []string{"test_alias"}, Value: &Parser{}}),
+		Flag:     NewGenericFlag(&cli.GenericFlag{Name: "test", Aliases: []string{"test_alias"}, Value: &Parser{}}),
 		FlagName: "test_alias",
 		MapValue: v,
 	}

diff --git a/flag-spec.yaml b/flag-spec.yaml
@@ -55,7 +55,12 @@ flag_types:
       - { name: Layout, type: string }
       - { name: Timezone, type: "*time.Location" }
 
-  # TODO: enable UintSlice
-  # UintSlice: {}
-  # TODO: enable Uint64Slice once #1334 lands
-  # Uint64Slice: {}
+  UintSlice: 
+    value_pointer: true
+    skip_interfaces:
+      - fmt.Stringer
+  Uint64Slice: 
+    value_pointer: true
+    skip_interfaces:
+      - fmt.Stringer
+