Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add transformer in- and out-going voltages to reporting #265

Merged
merged 8 commits into from
Jul 31, 2023
Merged

Add transformer in- and out-going voltages to reporting #265

merged 8 commits into from
Jul 31, 2023

Conversation

vtnate
Copy link
Collaborator

@vtnate vtnate commented Jul 24, 2023

Pull Request Description

  • Read the transformer voltage from Model.json
    • Generated by OpenDSS/Ditto-Reader
  • Put the transformer voltages into scenario_report_opendss.json with other transformer data
  • Use hash symbols instead of strings for other transformer data as well
  • Use Pathname for paths, instead of File.join working with strings
  • Fix indenting in Disco post-processor file.

Checklist (Delete lines that don't apply)

  • All ci tests pass (green)
  • This branch is up-to-date with develop

@vtnate vtnate requested a review from kflemin July 24, 2023 21:23
@vtnate vtnate self-assigned this Jul 24, 2023
vtnate
vtnate commented Jul 24, 2023
View reviewed changes
lib/urbanopt/scenario/scenario_post_processor_opendss.rb Outdated
Comment on lines 209 to 210
transformer_report.power_distribution.tx_incoming_voltage = t_res[t_key][:incoming_voltage]
transformer_report.power_distribution.tx_outgoing_voltage = t_res[t_key][:outgoing_voltage]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kflemin Are there better output names than tx_incoming_voltage and tx_outgoing_voltage in the report? If so, we'll need to change both here and in urbanopt/urbanopt-reporting-gem#138

@vtnate vtnate mentioned this pull request Jul 28, 2023
Merged
kflemin
kflemin approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@kflemin kflemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!!

@vtnate vtnate merged commit 48b4794 into develop Jul 31, 2023
@vtnate vtnate deleted the more-than-meets-the-eye branch July 31, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kflemin kflemin kflemin approved these changes

Assignees

@vtnate vtnate

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtnate @kflemin