Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove scenario-file (as a whole) from checks to re-run datapoints #232

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

vtnate
Copy link
Collaborator

@vtnate vtnate commented Feb 24, 2022

Resolves CLI issue 237

Pull Request Description

The change in this PR means changes to the scenario-file do not trigger re-running every datapoint (removes it from the 2nd list below).

Documenting out-of-date datapoints:

This check looks inside each datapoint specified in the scenario-file.

  • If one of the datapoints does not have a finished.job file or an out.osw file, it is re-run
  • If the datapoint folder doesn't exist, it is re-run

If the most recent change to any out.osw file is older than the most recent change to any of the following project-dir files, the entire scenario is re-run.

  • in.osw
  • feature file
  • Gemfile
  • Gemfile.lock
  • Anything inside the mappers folder

Checklist (Delete lines that don't apply)

  • Unit tests have been added or updated
  • Documentation has been modified as needed
  • All ci tests pass (green)
  • An issue has been created (which will be used for the changelog)
  • This branch is up-to-date with develop

@vtnate vtnate added the enhancement New feature or request label Feb 24, 2022
@vtnate vtnate requested a review from kflemin February 24, 2022 18:05
@vtnate vtnate self-assigned this Feb 24, 2022
@vtnate vtnate merged commit 5fe2aa5 into develop Feb 24, 2022
@vtnate vtnate deleted the out-of-date-datapoints branch February 24, 2022 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify the "datapoint is out of date" process
2 participants