-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding emissions results to UO reports #108
Conversation
-updated measure.rb -updated schema/scenario_schema.json -updated reporting/default_reports/reporting_period.rb
@@ -57,14 +57,16 @@ class ReportingPeriod | |||
:net_site_energy_kwh, :net_source_energy_kwh, :total_utility_cost_dollar, :net_utility_cost_dollar, :utility_costs_dollar, :electricity_kwh, :natural_gas_kwh, :propane_kwh, :fuel_oil_kwh, :other_fuels_kwh, :district_cooling_kwh, | |||
:district_heating_kwh, :water_qbft, :electricity_produced_kwh, :end_uses, :energy_production_kwh, :photovoltaic, | |||
:fuel_type, :total_cost_dollar, :usage_cost_dollar, :demand_cost_dollar, :comfort_result, :time_setpoint_not_met_during_occupied_cooling, | |||
:time_setpoint_not_met_during_occupied_heating, :time_setpoint_not_met_during_occupied_hours, :hours_out_of_comfort_bounds_PMV, :hours_out_of_comfort_bounds_PPD #:nodoc: | |||
:time_setpoint_not_met_during_occupied_heating, :time_setpoint_not_met_during_occupied_hours, :hours_out_of_comfort_bounds_PMV, :hours_out_of_comfort_bounds_PPD, | |||
:emissions_kg, :future_annual_emissions_kg, :future_hourly_emissions_kg, :historical_annual_emissions_kg, :historical_hourly_emissions_kg #:nodoc: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other projects (BuildingSync, SEED, BPS efforts in general) are standardizing on this unit for reporting GHG emissions: MtCO2e (metric ton CO2e)
Should we also do that, or keep it in kg?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can change it later if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good except for the stray comma and a return at the end of the file. thanks!
@@ -234,13 +234,16 @@ def energyPlusOutputRequests(runner, user_arguments) | |||
'District Cooling Inlet Temperature', 'District Cooling Outlet Temperature', | |||
'District Heating Hot Water Rate', 'District Heating Mass Flow Rate', | |||
'District Heating Inlet Temperature', 'District Heating Outlet Temperature', 'Cooling Coil Total Cooling Rate', | |||
'Heating Coil Heating Rate', 'ExteriorEquipment:Electricity'] | |||
'Heating Coil Heating Rate', 'ExteriorEquipment:Electricity', ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this comma be here?
@@ -978,4 +999,4 @@ | |||
} | |||
} | |||
} | |||
} | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a return at the end of the file
- removed comma at the end of array - added empty line at the end on the scenario_schema.json
- changes kg to mt - added emissions intensity reporting
Resolves #[issue number here]
Pull Request Description
added emission results to csv reports
Checklist (Delete lines that don't apply)