Residential: add unit tests for BuildResidentialModel #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtnate
reviewed
Dec 13, 2023
example_project/resources/hpxml-measures/BuildResidentialHPXML/measure.rb
Show resolved
Hide resolved
vtnate
approved these changes
Dec 21, 2023
There was a problem hiding this comment.
This is where the magic happens. I love that we have more tests.
| @@ -780,4 +780,24 @@ task update_all: [:run_all, :post_process_all, :visualize_all] do | |||
| # run and post_process all the scenarios | |||
| end | |||
|
|
|||
| desc 'Run residential tasks' | |||
| namespace :residential do | |||
| desc 'Update residential resources' | |||
There was a problem hiding this comment.
Thank you for making this rake task! This will reduce my anxiety on this step a lot. 🙌
| - name: Update gems | ||
| run: | | ||
| bundle update | ||
| bundle exec certified-update | ||
| - name: Test residential measure variations | ||
| run: bundle exec rake residential:measure_tests |
There was a problem hiding this comment.
So automatic. Such test. Very variety. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
example_project/measures/BuildResidentialModel/tests/test_build_residential_model.rb. Using this test file, we can check combinations of assignments in theargshash (which is what Baseline.rb populates and sends into BuildResidentialModel).Adds new rake tasks:
residential:measure_tests: runs the unit tests found inBuildResidentialModel/tests/test_build_residential_model.rbresidential:update_resources: git clones (as opposed to git subtree) the OpenStudio-HPXML repository with a depth of 1 and renames it to "hpxml-measures"Refactors a bunch of residential -related methods into their own resource files:
example_project/mappers/residential:util.rb(contains the generalresidentialmethod and allresidential_xxxcategory methods)templateiecc(contains all the*.tsvfiles)util.rb(containsresidential_templatemethod and related helper methods)