Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OpenStudio 3.7 #188

Merged
merged 42 commits into from
Jan 18, 2024
Merged

Support OpenStudio 3.7 #188

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
00acd3d
point to os37-rc2 in CI, and remove old comments
vtnate Nov 13, 2023
91746ec
start with local branches with newer dependencies
vtnate Nov 13, 2023
d90788a
Merge commit 'da0ad127a4c506fe70c078224fc18cf711b70181' into os37
vtnate Nov 13, 2023
da0ad12
Squashed 'example_project/resources/hpxml-measures/' changes from e2f…
vtnate Nov 13, 2023
410b645
get new error message in baseline mapper from cli code
vtnate Nov 13, 2023
f33b774
openstudio:update_measures which just added license text
vtnate Nov 13, 2023
0fb5b8e
point to branches to test OS3.7
vtnate Nov 20, 2023
29a5b7d
also specify core-gem in this repo, at least during testing
vtnate Nov 20, 2023
7b74925
use official OS version 3.7.0 in CI
vtnate Nov 20, 2023
31ec325
Squashed 'example_project/resources/hpxml-measures/' changes from d74…
vtnate Nov 20, 2023
c829f41
Merge commit '31ec325904a8cc59a471301c643c124327e49694' into os37
vtnate Nov 20, 2023
c080412
update BuildResidentialModel measure
vtnate Nov 20, 2023
f0616d8
change building location even for osm buildings
vtnate Nov 30, 2023
2794d20
remove hardcoded local weatherfile path from osm buildings
vtnate Nov 30, 2023
2aff9bb
Update to OS-HPXML v1.7.0 (#189)
joseph-robertson Dec 1, 2023
5414635
add chilled_water_storage to <run/process/clear/visualize>_all rake t…
vtnate Dec 1, 2023
1da6608
point to davids os37-rc branch of load-flex-gem
vtnate Dec 8, 2023
181fb3f
fix license link in copyright notice
vtnate Dec 8, 2023
e134a73
adding geometry orientation and aspect ratio example for single-famil…
kflemin Dec 8, 2023
6aec0ab
updating openstudio measure gems versions
kflemin Dec 15, 2023
20865e1
use newly released version of openstudio-geb-gem
vtnate Dec 15, 2023
6aedc6d
allow allow_local to work again
vtnate Dec 18, 2023
ddfdc00
use http in example project_dir gemfile, to help installer
vtnate Dec 21, 2023
38b32fe
point gemfiles to develop branches of openstudio gems
vtnate Dec 21, 2023
a3879ea
use http://rubygems.org in gemfile
vtnate Dec 21, 2023
b04b5ce
Residential: add unit tests for BuildResidentialModel (#191)
joseph-robertson Dec 21, 2023
a441e4a
bump to newly released uo gems
vtnate Jan 12, 2024
a5ee888
bump action version in codeql workflow
vtnate Jan 12, 2024
cdd8c07
update license text to match reopt-gem, fix link, & include 2024
vtnate Jan 16, 2024
0ddf3b3
remove top-level requirement for oga (still needed for residential)
vtnate Jan 16, 2024
05debdf
use high-efficiency mapper on a residential building
vtnate Jan 16, 2024
101826b
ugh, use develop branch when favoring local gems
vtnate Jan 16, 2024
c5cabb8
ugh, fix copy/paste error in gemfile for local gems
vtnate Jan 16, 2024
71d8bba
yikes, I am crushing the stupid copy/paste mistakes today
vtnate Jan 16, 2024
7e2124d
re-install oga for residential measure-tests workflow
vtnate Jan 16, 2024
f19d355
no need for duplicate residential measure_test runs in CI
vtnate Jan 16, 2024
c3e681a
more specific name of failure artifact on github
vtnate Jan 16, 2024
8fcf9df
different way of specifying json & csv. Maybe this is cleaner?
vtnate Jan 16, 2024
910113f
Revert "different way of specifying json & csv. Maybe this is cleaner?"
vtnate Jan 16, 2024
3fb53cd
Update Gemfile dependencies
kflemin Jan 17, 2024
eb7f4eb
fix another copy paste error
vtnate Jan 18, 2024
f1157f0
Merge branch 'os37' of https://github.com/urbanopt/urbanopt-example-g…
vtnate Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion example_project/example_project_combined.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -650,7 +650,9 @@
"system_type": "Residential - furnace and central air conditioner",
"heating_system_fuel_type": "natural gas",
"onsite_parking_fraction": 1,
"template": "Residential IECC 2015 - Customizable Template Sep 2020"
"template": "Residential IECC 2015 - Customizable Template Sep 2020",
"geometry_unit_orientation": 90.0,
"geometry_unit_aspect_ratio" : 1.0
Comment on lines +654 to +655
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are only applicable (valid) for SFD and SFA buildings? For example, I'm pretty sure geometry_unit_orientation is determined using some logic right around here for MF buildings.

There is also some language around these inputs here in the URBANopt docs that may need to be updated.

@kflemin

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the clarifications @joseph-robertson, I'll add language to the docs related to that!

},
"geometry": {
"type": "Polygon",
Expand Down
14 changes: 14 additions & 0 deletions example_project/mappers/Baseline.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -752,6 +752,20 @@ def create_osw(scenario, features, feature_names)
rescue StandardError
end

# Geometry Orientation and Aspect Ratio
# Orientation (North=0, East=90, South=180, West=270)
begin
args[:geometry_unit_orientation] = feature.geometry_unit_orientation
rescue StandardError
end

# Aspect Ratio
# The ratio of front/back wall length to left/right wall length for the unit, excluding any protruding garage wall area.
begin
args[:geometry_unit_aspect_ratio] = feature.geometry_unit_aspect_ratio
rescue StandardError
end

# Occupancy Calculation Type
begin
if feature.occupancy_calculation_type == 'operational'
Expand Down