Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple unit test and support processing UO results only #4

Merged
merged 12 commits into from
Oct 14, 2024

Conversation

nllong
Copy link
Member

@nllong nllong commented Sep 23, 2024

This PR does a few things:

  1. Enable processing of results of running only URBANopt (without DES and no real meter data)
  2. Create building level tabular data of energy, intensities, and gross floor areas
  3. Allow aggregations of all the building loads to be used in a single DES model. If there is no sharing of energy between buildings (and no sources/sinks between buildings), then this will enable much faster run times in UO DES.

@nllong nllong requested a review from vtnate September 23, 2024 18:22
Copy link
Contributor

@vtnate vtnate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically this looks fine. Couple dumb nit-picks. My main problem is that this repo doesn't have a readme. Can you add some sort of instructions on how to use it? I don't know how to test your code.

urbanopt_des/urbanopt_geojson.py Outdated Show resolved Hide resolved
urbanopt_des/urbanopt_geojson.py Show resolved Hide resolved
urbanopt_des/urbanopt_analysis.py Show resolved Hide resolved
urbanopt_des/urbanopt_results.py Outdated Show resolved Hide resolved
urbanopt_des/urbanopt_results.py Show resolved Hide resolved
@nllong nllong changed the title Support processing UO results only Add simple unit test and support processing UO results only Oct 14, 2024
@nllong
Copy link
Member Author

nllong commented Oct 14, 2024

@vtnate -- i made the updates and includes a very simple unit test.

The issue now is that I can't update poetry.lock due to an SSL issue. Can you try? Just checkout this branch and run poetry update. I keep getting this message

Updating dependencies
Resolving dependencies... (0.4s)

HTTPSConnectionPool(host='github.com', port=443): Max retries exceeded with url: /urbanopt/modelica-builder.git/info/refs?service=git-upload-pack (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1000)')))

@vtnate
Copy link
Contributor

vtnate commented Oct 14, 2024

I didn't have the SSL issue, but Poetry did tell me there was some incompatibility with the toml library. The internet tells me that tomli is the blessed package now, not toml (and in Python 3.11 it's included in Python as tomllib). When Poetry gives me grief I delete the poetry.lock file and do poetry install to start from scratch. That usually helps Poetry get over its confusion.

@vtnate
Copy link
Contributor

vtnate commented Oct 14, 2024

Whoa. Tomli wasn't happy either, and then I got 429 Client Error: Too Many Requests for url: https://github.com/antlr4-python3-runtime/ (all from poetry install). Maybe it's antlr that's struggling?

@nllong
Copy link
Member Author

nllong commented Oct 14, 2024

yeah, it works if you comment out Modelica-builder, it is will create the updated lock file. Crazy, right?

@nllong nllong merged commit 58fef74 into develop Oct 14, 2024
3 checks passed
@nllong nllong deleted the support-uo-only branch October 14, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants