-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simple unit test and support processing UO results only #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically this looks fine. Couple dumb nit-picks. My main problem is that this repo doesn't have a readme. Can you add some sort of instructions on how to use it? I don't know how to test your code.
@vtnate -- i made the updates and includes a very simple unit test. The issue now is that I can't update poetry.lock due to an SSL issue. Can you try? Just checkout this branch and run Updating dependencies
Resolving dependencies... (0.4s)
HTTPSConnectionPool(host='github.com', port=443): Max retries exceeded with url: /urbanopt/modelica-builder.git/info/refs?service=git-upload-pack (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1000)'))) |
I didn't have the SSL issue, but Poetry did tell me there was some incompatibility with the |
Whoa. Tomli wasn't happy either, and then I got |
yeah, it works if you comment out Modelica-builder, it is will create the updated lock file. Crazy, right? |
This PR does a few things: