Change thermal connectors to be measured in meters #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtnate
changed the title
JingWang-CUB
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any background context you want to provide?
This is a companion to urbanopt/urbanopt-geojson-gem#283, where we're changing thermal connectors to be measured in SI units (meters) instead of IP units (feet).
Electrical connectors are staying in IP units, at least temporarily, due to the connection to other packages (rnm, opendss, ditto, etc) so we can evaluate the impacts of changing to SI units.
What does this PR accomplish?
How should this be manually tested?
What are the relevant tickets?
Screenshots (if appropriate)