Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support international weather locations #654

Merged
merged 5 commits into from
Sep 9, 2024
Merged

Conversation

vtnate
Copy link
Contributor

@vtnate vtnate commented Sep 6, 2024

Any background context you want to provide?

We were only supporting USA weather locations until now. This PR enables any location from www.energyplus.net/weather to be used (as of Sep 4, 2024). Major caveat: This only accepts *.mos weather files, which as of now are only available on the website for USA locations. Once mos weather files for all locations on the website are available, this code is ready to take advantage.

What does this PR accomplish?

  • Handle all locations provided by https://energyplus.net/weather. Requires a weather file in *.mos format to be avaailable from that website, which as of today is limited to USA locations.
  • Adds tests for this using the CLI and using the code directly

How should this be manually tested?

Provide a valid weather epw filename for any location outside the USA in your geojson file. Observe that the EPW is downloaded correctly and an error is raised if the mos format file isn't found.

What are the relevant tickets?

Resolves #651

@vtnate vtnate added the enhancement New feature or request label Sep 6, 2024
@vtnate vtnate self-assigned this Sep 6, 2024
@vtnate vtnate requested review from nllong and amyeallen1 September 9, 2024 15:39
Copy link
Member

@nllong nllong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicely done--looks like we should have handled this from the beginning. Thanks for updating!

@vtnate vtnate merged commit e02a350 into develop Sep 9, 2024
10 checks passed
@vtnate vtnate deleted the international-weather branch September 9, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for international location weather files
2 participants