Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiple GHEs in a single district #644

Merged
merged 140 commits into from
Sep 25, 2024
Merged

Support multiple GHEs in a single district #644

merged 140 commits into from
Sep 25, 2024

Conversation

vtnate
Copy link
Contributor

@vtnate vtnate commented Jul 11, 2024 •
edited
Loading

Any background context you want to provide?

Previously we only supported a single GHE in a thermal loop

What does this PR accomplish?

  • Reads all ghe_specific_params from the sys-param file
  • Instantiates a separate borefield object for each GHE
  • Couples the district together

How should this be manually tested?

  1. Build a Modelica model using the multi-ghe test
  2. Load the model in Dymola (by hand)
  3. Simulate in Dymola
    • OM crashes when trying to open a model that large :(

Future work:

  • Ensure this will simulate natively inside GMT using OM

@vtnate vtnate added the enhancement New feature or request label Jul 11, 2024
@vtnate vtnate self-assigned this Jul 11, 2024
vtnate and others added 24 commits July 11, 2024 09:42
@vtnate
improve error message for missing g-function file
05a34db
@vtnate
additional g-function files to match the test sys-param files
a34f255
@vtnate
update borefield test to work in the multi-ghe paradigm
c5be9cc
@vtnate
improve help text in CLI
9508270
@vtnate
more explicitly process different types of district sys-params
390a88e
@vtnate
clean up generation call, load loop order, load multiple ghes
1d23f70
@vtnate
use new parameter for district_type argument
90a775b
@vtnate
load ghe loop order in the correct place
8df9749
@vtnate
move soil parameters out of ghe-specific and into all 5G parameters
a039d5b
@vtnate
use new location of soil parameters
7db291d
@vtnate
don't require soil in the incorrect place, duh
2d44053
@vtnate
use new fifth_generation tag properly in 5G tests
d669240
@vtnate
fix test sys-param files for 5G districts
47094c5
@vtnate
add graceful error message when sizing output from TN is not found
c5e75b8
@vtnate
remove outdated TODO message
364694b
@vtnate
remove unused test sys-param file
e1bb5c4
@vtnate
comment noisy debug log lines
07c30fa
@JingWang-CUB
update geojson and sys_param paths
00fcf08
@JingWang-CUB
add project folder for testing multi-ghe
b4883e9
@JingWang-CUB
update building load profiles
c0876c9
@JingWang-CUB
modify paths pointing to mos files and ghe_dir
649a00a
@JingWang-CUB
add ghe sizing results to ghe_dir
b76eaa8
@JingWang-CUB
move soil and add horizontal piping parameters
2a0134d
@vtnate
pre-commit formatting
d9d1f72
JingWang-CUB and others added 19 commits September 9, 2024 16:24
@JingWang-CUB
fix for multi ghes
6dbd378
@JingWang-CUB
expand number of ports for multi ghes
f1855c6
@vtnate
Merge branch 'develop' into ghe-couplings
882c170
@vtnate
fix dict lookup in instance template
6fb0c22
@vtnate
allow more statements in ruff
a98bad4
@vtnate
linting & formatting
010cfdd
@JingWang-CUB
increase central pump head for the multi-ghe test
ba91319
@JingWang-CUB
reduce flow rate per borehole
9db96bc
@JingWang-CUB
Merge branch 'ghe-couplings' of https://github.com/urbanopt/geojson-m…
d2b182e 
…odelica-translator into ghe-couplings
@vtnate
Merge branch 'develop' into ghe-couplings
9ba10a8
@vtnate
only simulate multi-ghe with Dymola, temporarily
6150312
@vtnate
clarify comment in test_uo_des.py
19f9d77
@JingWang-CUB
fix couplings so test_uo_des won't break
c84165f
@JingWang-CUB
Merge branch 'ghe-couplings' of https://github.com/urbanopt/geojson-m…
e1b518f 
…odelica-translator into ghe-couplings
@vtnate
formatting
114f2d6
@vtnate
copy scenario file to test 13-building data dir
22b2061
@vtnate
ignore new files generated by updated CLI test
10ca170
@vtnate
Revert "ignore new files generated by updated CLI test"
df1dc5e 
This reverts commit 10ca170.
@vtnate
Revert "copy scenario file to test 13-building data dir"
2faad0d 
This reverts commit 22b2061.
@vtnate vtnate marked this pull request as ready for review September 17, 2024 17:04
@vtnate vtnate requested review from nllong and mitchute September 17, 2024 17:08
nllong
nllong approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@nllong nllong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is hands down one of the most impressive PRs that I have seen. Most excellent work team!

image

@vtnate vtnate merged commit 1ba832d into develop Sep 25, 2024
10 checks passed
@vtnate vtnate deleted the ghe-couplings branch September 25, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nllong nllong nllong approved these changes

@mitchute mitchute mitchute approved these changes

Assignees

@vtnate vtnate

@JingWang-CUB JingWang-CUB

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vtnate @nllong @mitchute @JingWang-CUB