Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax pandas version requirement #628

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Relax pandas version requirement #628

merged 2 commits into from
Apr 5, 2024

Conversation

vtnate
Copy link
Contributor

@vtnate vtnate commented Mar 28, 2024

Any background context you want to provide?

The main urbanopt SDK was having troubles with incompatible dependencies. Pandas was the primary culprit. Relaxing this version constraint among all the relevant packages will help us escape dependency hell.

What does this PR accomplish?

Allows Pandas >=2 <3

How should this be manually tested?

CI is sufficient for the mechanics. Happy to have a philosophy discussion if there is a preferred technique to escape dependency hell.

What are the relevant tickets?

urbanopt/urbanopt-cli#459

@vtnate vtnate added dependencies Pull requests that update a dependency file ignore-for-release Exclude this PR from release notes labels Mar 28, 2024
@vtnate vtnate self-assigned this Mar 28, 2024
@vtnate vtnate requested a review from nllong March 29, 2024 17:37
Copy link
Member

@nllong nllong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@vtnate vtnate merged commit 3f83b7e into develop Apr 5, 2024
10 checks passed
@vtnate vtnate deleted the relax-pandas-dep branch April 5, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ignore-for-release Exclude this PR from release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants