Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements to the CLI #620

Merged
merged 3 commits into from
Feb 13, 2024
Merged

Minor improvements to the CLI #620

merged 3 commits into from
Feb 13, 2024

Conversation

vtnate
Copy link
Contributor

@vtnate vtnate commented Feb 7, 2024

Any background context you want to provide?

I found a bug in uo-cli when it was calling gmt-cli, which inspired me to look at gmt-cli. Found there were a few inconsistencies and missing documentation, so I cleaned that up. Then needed to update the tests because of it.

What does this PR accomplish?

  • Make a few Click arguments options instead
    • This is consistent with the rest of our CLI, and properly categorizes required and optional arguments in the help text
  • Add help text for new & existing cli options
  • Update test call due to these changes

How should this be manually tested?

CI is sufficient

What are the relevant tickets?

This PR in the UO-CLI fixes the wrapper to our cli, and inspired this investigation.

@vtnate vtnate added the enhancement New feature or request label Feb 7, 2024
@vtnate vtnate self-assigned this Feb 7, 2024
@vtnate vtnate marked this pull request as ready for review February 8, 2024 15:21
@vtnate vtnate requested a review from nllong February 8, 2024 15:23
Copy link
Member

@nllong nllong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet!

@nllong nllong merged commit 706f3e3 into develop Feb 13, 2024
10 checks passed
@nllong nllong deleted the cli-improvements branch February 13, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants