Remove unnecessary argument in ThrowIfNullOrEmpty (OrchardCMS#15272)

Co-authored-by: Hisham Bin Ateya <[email protected]>
urbanit · Mar 18, 2024 · de26a04 · de26a04
1 parent 4d7bc63
commit de26a04
Show file tree

Hide file tree

Showing 7 changed files with 14 additions and 14 deletions.
diff --git a/...rchardCore.Modules/OrchardCore.Search.Elasticsearch/ElasticsearchIndexPermissionHelper.cs b/...rchardCore.Modules/OrchardCore.Search.Elasticsearch/ElasticsearchIndexPermissionHelper.cs
@@ -14,7 +14,7 @@ public class ElasticsearchIndexPermissionHelper
 
     public static Permission GetElasticIndexPermission(string indexName)
     {
-        ArgumentException.ThrowIfNullOrEmpty(indexName, nameof(indexName));
+        ArgumentException.ThrowIfNullOrEmpty(indexName);
 
         if (!_permissions.TryGetValue(indexName, out var permission))
         {

diff --git a/src/OrchardCore/OrchardCore.ContentManagement.Abstractions/ContentItemExtensions.cs b/src/OrchardCore/OrchardCore.ContentManagement.Abstractions/ContentItemExtensions.cs
@@ -27,7 +27,7 @@ public static bool TryGet<TPart>(this ContentItem contentItem, out TPart part) w
         /// <returns>true if a part found, otherwise false.</returns>
         public static bool TryGet<TPart>(this ContentItem contentItem, string name, out TPart part) where TPart : ContentPart
         {
-            ArgumentException.ThrowIfNullOrEmpty(name, nameof(name));
+            ArgumentException.ThrowIfNullOrEmpty(name);
 
             try
             {

diff --git a/src/OrchardCore/OrchardCore.ContentManagement/ContentDefinitionManager.cs b/src/OrchardCore/OrchardCore.ContentManagement/ContentDefinitionManager.cs
@@ -70,7 +70,7 @@ public async Task<IEnumerable<ContentPartDefinition>> ListPartDefinitionsAsync()
 
         public async Task<ContentTypeDefinition> LoadTypeDefinitionAsync(string name)
         {
-            ArgumentException.ThrowIfNullOrEmpty(name, nameof(name));
+            ArgumentException.ThrowIfNullOrEmpty(name);
 
             if (_scopedTypeDefinitions.TryGetValue(name, out var typeDefinition))
             {
@@ -84,7 +84,7 @@ public async Task<ContentTypeDefinition> LoadTypeDefinitionAsync(string name)
 
         public async Task<ContentTypeDefinition> GetTypeDefinitionAsync(string name)
         {
-            ArgumentException.ThrowIfNullOrEmpty(name, nameof(name));
+            ArgumentException.ThrowIfNullOrEmpty(name);
 
             var document = await _contentDefinitionStore.GetContentDefinitionAsync();
 
@@ -95,7 +95,7 @@ public async Task<ContentTypeDefinition> GetTypeDefinitionAsync(string name)
 
         public async Task<ContentPartDefinition> LoadPartDefinitionAsync(string name)
         {
-            ArgumentException.ThrowIfNullOrEmpty(name, nameof(name));
+            ArgumentException.ThrowIfNullOrEmpty(name);
 
             if (_scopedPartDefinitions.TryGetValue(name, out var partDefinition))
             {
@@ -109,7 +109,7 @@ public async Task<ContentPartDefinition> LoadPartDefinitionAsync(string name)
 
         public async Task<ContentPartDefinition> GetPartDefinitionAsync(string name)
         {
-            ArgumentException.ThrowIfNullOrEmpty(name, nameof(name));
+            ArgumentException.ThrowIfNullOrEmpty(name);
 
             var document = await _contentDefinitionStore.GetContentDefinitionAsync();
 
@@ -120,7 +120,7 @@ public async Task<ContentPartDefinition> GetPartDefinitionAsync(string name)
 
         public async Task DeleteTypeDefinitionAsync(string name)
         {
-            ArgumentException.ThrowIfNullOrEmpty(name, nameof(name));
+            ArgumentException.ThrowIfNullOrEmpty(name);
 
             var document = await _contentDefinitionStore.LoadContentDefinitionAsync();
 
@@ -136,7 +136,7 @@ public async Task DeleteTypeDefinitionAsync(string name)
 
         public async Task DeletePartDefinitionAsync(string name)
         {
-            ArgumentException.ThrowIfNullOrEmpty(name, nameof(name));
+            ArgumentException.ThrowIfNullOrEmpty(name);
 
             var document = await _contentDefinitionStore.LoadContentDefinitionAsync();
 

diff --git a/src/OrchardCore/OrchardCore.Data.YesSql/SqliteHelper.cs b/src/OrchardCore/OrchardCore.Data.YesSql/SqliteHelper.cs
@@ -43,8 +43,8 @@ public static string GetConnectionString(SqliteOptions sqliteOptions, string dat
     /// <returns></returns>
     public static string GetConnectionString(SqliteOptions sqliteOptions, string databaseFolder, string databaseName, SqliteOpenMode sqliteOpenMode)
     {
-        ArgumentException.ThrowIfNullOrEmpty(databaseFolder, nameof(databaseFolder));
-        ArgumentException.ThrowIfNullOrEmpty(databaseName, nameof(databaseName));
+        ArgumentException.ThrowIfNullOrEmpty(databaseFolder);
+        ArgumentException.ThrowIfNullOrEmpty(databaseName);
 
         return GetSqliteConnectionStringBuilder(sqliteOptions, databaseFolder, databaseName, sqliteOpenMode).ToString();
     }

diff --git a/src/OrchardCore/OrchardCore.DisplayManagement/Views/ShapeViewModel.cs b/src/OrchardCore/OrchardCore.DisplayManagement/Views/ShapeViewModel.cs
@@ -16,7 +16,7 @@ public ShapeViewModel()
 
         public ShapeViewModel(string shapeType)
         {
-            ArgumentException.ThrowIfNullOrEmpty(shapeType, nameof(shapeType));
+            ArgumentException.ThrowIfNullOrEmpty(shapeType);
 
             Metadata.Type = shapeType;
         }

diff --git a/src/OrchardCore/OrchardCore.Search.AzureAI.Core/Models/AzureAISearchIndexMap.cs b/src/OrchardCore/OrchardCore.Search.AzureAI.Core/Models/AzureAISearchIndexMap.cs
@@ -21,7 +21,7 @@ public AzureAISearchIndexMap()
 
     public AzureAISearchIndexMap(string azureFieldKey, Types type)
     {
-        ArgumentException.ThrowIfNullOrEmpty(azureFieldKey, nameof(azureFieldKey));
+        ArgumentException.ThrowIfNullOrEmpty(azureFieldKey);
 
         AzureFieldKey = azureFieldKey;
         Type = type;

diff --git a/...OrchardCore/OrchardCore.Search.AzureAI.Core/Services/AzureAISearchIndexDocumentManager.cs b/...OrchardCore/OrchardCore.Search.AzureAI.Core/Services/AzureAISearchIndexDocumentManager.cs
@@ -32,8 +32,8 @@ public class AzureAIIndexDocumentManager(
 
     public async Task<IEnumerable<SearchDocument>> SearchAsync(string indexName, string searchText, SearchOptions searchOptions = null)
     {
-        ArgumentException.ThrowIfNullOrEmpty(indexName, nameof(indexName));
-        ArgumentException.ThrowIfNullOrWhiteSpace(searchText, nameof(searchText));
+        ArgumentException.ThrowIfNullOrEmpty(indexName);
+        ArgumentException.ThrowIfNullOrWhiteSpace(searchText);
 
         var client = GetSearchClient(indexName);