Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

otelsql: Record error and status when SQL returns an error #115

Closed
empire opened this issue Dec 6, 2023 · 1 comment · Fixed by #114
Closed

otelsql: Record error and status when SQL returns an error #115

empire opened this issue Dec 6, 2023 · 1 comment · Fixed by #114

Comments

@empire
Copy link
Contributor

empire commented Dec 6, 2023

Currently, when SQL returns an error, the error is not recorded and the status is not set.

Pull request: #114
@empire empire mentioned this issue Dec 6, 2023
Merged
@empire empire changed the title otelsql: Record error and status when SQL returns an error #114 otelsql: Record error and status when SQL returns an error Dec 6, 2023
empire added a commit to empire/opentelemetry-go-extra that referenced this issue Dec 10, 2023
@empire
fix(otelsql): record error and status when SQL returns an error
1716db5 
The Span ends early when SQL returns an error, which prevents Otelsql from recording the error.
This commit fixes this issue by deferring the Span.End() call.

Fixes: uptrace#115
@empire
Copy link
Contributor Author

empire commented Mar 16, 2024

Hi @vmihailenco,
I hope you are doing well. Could you please take a look at this issue and the PR?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(otelsql): record error and status when SQL returns an error empire/opentelemetry-go-extra
1 participant
@empire