Snapshot is only required to contain Targets versions. #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add a note about malicious mirrors being out of scope but discussed in the Mercury paper. Signed-off-by: Patrick Vacek <[email protected]>
This was referenced Mar 26, 2019
trishankatdatadog
requested changes
Mar 26, 2019
There was a problem hiding this comment.
Thanks @patrickvacek, LGTM
I recommend removing that bit and only mention the "Z number of bytes" 👍
The snapshot metadata is not required or recommended to contain the lengths of targets metadata. It just has versions. Signed-off-by: Patrick Vacek <[email protected]>
|
@trishankatdatadog Thanks for the suggestion. I've pushed a second commit that addresses the length issue. |
pattivacek
added a commit
to advancedtelematic/tuf-test-vectors
that referenced
this pull request
Mar 29, 2019
For more information, see: uptane/uptane-standard#90 uptane/uptane-standard#92 Signed-off-by: Patrick Vacek <[email protected]>
pattivacek
added a commit
to advancedtelematic/aktualizr
that referenced
this pull request
Mar 29, 2019
Uptane (and TUF) no longer require them. If they are there, we will use them, and if not, we skip them. This provides no real security benefit, but may help detect implementation faults. For more information, see: uptane/uptane-standard#90 uptane/uptane-standard#92 Signed-off-by: Patrick Vacek <[email protected]>
pattivacek
added a commit
to advancedtelematic/aktualizr
that referenced
this pull request
Apr 15, 2019
Uptane (and TUF) no longer require them. If they are there, we will use them, and if not, we skip them. This provides no real security benefit, but may help detect implementation faults. For more information, see: uptane/uptane-standard#90 uptane/uptane-standard#92 Signed-off-by: Patrick Vacek <[email protected]>
pattivacek
added a commit
to advancedtelematic/aktualizr
that referenced
this pull request
Apr 15, 2019
Uptane (and TUF) no longer require them. If they are there, we will use them, and if not, we skip them. This provides no real security benefit, but may help detect implementation faults. For more information, see: uptane/uptane-standard#90 uptane/uptane-standard#92 Signed-off-by: Patrick Vacek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add a note about malicious mirrors being out of scope but discussed in the Mercury paper.
Closes #90.
However, section 5.4.4.6 (How to check Targets metadata) still mentions that we should "[d]ownload the number of bytes either specified in the Snapshot metadata file, or some Z number of bytes [...]" despite that the Snapshot metadata does not mention anything about length. Should we say length is optional in snapshots, or remove that bit and only mention the "Z number of bytes"?