Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable ssl_verify_peer #264

Merged
merged 2 commits into from
Mar 29, 2015
Merged

Option to disable ssl_verify_peer #264

merged 2 commits into from
Mar 29, 2015

Conversation

electrical
Copy link

This allows the user to set ssl_verify_peer to false.
This can be required when running with a self signed cert

This allows the user to set ssl_verify_peer to false.
This can be required when running with a self signed cert
@electrical
Copy link
Author

Failed due to:
spec/docker_spec.rb:101 Line is >80 characters (86)
Perhaps an idea to exclude spec files?

@electrical
Copy link
Author

@tlunter could you take a look at this if you have the time? thanks!

@tlunter
Copy link
Contributor

tlunter commented Mar 18, 2015

@electrical Sure thing. Feel free to up --style-measure in .cane to 100. 80 feels a bit limited and that line reads fine to me. Is ssl_verify_peer set to true by default because of scheme: 'https' unless set to false explicitly?

@electrical
Copy link
Author

Hi, sorry for the delay in response.
I don't validate yet if ssl is enabled first to see if ssl_verify_peer makes sense since it has no impact when ssl is not enabled.
I'll change the style-measure to 100.
Thanks!

@electrical
Copy link
Author

@tlunter PR updated. If this could be merged and released it would help users with boot2docker allot using beaker. Thanks!

tlunter added a commit that referenced this pull request Mar 29, 2015
@tlunter tlunter merged commit 2df51e1 into upserve:master Mar 29, 2015
@tlunter
Copy link
Contributor

tlunter commented Mar 29, 2015

@electrical released in v1.21.0. thanks!

@electrical
Copy link
Author

Very much appreciated :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants