Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not crash when the scanned card is not associated with any account #29

Merged
merged 1 commit into from
Mar 5, 2017

Conversation

kjagiello
Copy link
Member

@kjagiello kjagiello commented Mar 5, 2017

Solves #28

@kjagiello kjagiello self-assigned this Mar 5, 2017
@kjagiello kjagiello changed the title Do not crash when the scanned card is not associated with any account (#28) Do not crash when the scanned card is not associated with any account Mar 5, 2017
@codecov
Copy link

codecov bot commented Mar 5, 2017

Codecov Report

Merging #29 into develop will increase coverage by 1.48%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop      #29      +/-   ##
===========================================
+ Coverage    87.96%   89.44%   +1.48%     
===========================================
  Files           73       73              
  Lines         2500     2519      +19     
  Branches       134      135       +1     
===========================================
+ Hits          2199     2253      +54     
+ Misses         283      244      -39     
- Partials        18       22       +4
Impacted Files Coverage Δ
src/foobar/views.py 94.11% <100%> (+7.45%)
src/foobar/tests/test_views.py 100% <100%> (ø)
src/shop/models.py 84.07% <0%> (ø)
src/shop/admin.py 59.69% <0%> (+1.52%)
src/wallet/admin.py 91.3% <0%> (+4.34%)
src/foobar/admin.py 69.56% <0%> (+9.42%)
src/utils/models.py 100% <0%> (+33.33%)
src/utils/widgets.py 100% <0%> (+50%)
src/utils/forms.py 100% <0%> (+50%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78875cd...993d086. Read the comment docs.

@kjagiello kjagiello merged commit ea436e8 into develop Mar 5, 2017
@kjagiello kjagiello deleted the bugfix/issue-28 branch March 12, 2017 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant