-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from Yarn to pnpm #379
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
ProchaLu
changed the title
Update installation command to use pnpm
Update installation commands to use pnpm
Apr 12, 2023
karlhorky
reviewed
Apr 12, 2023
karlhorky
reviewed
Apr 13, 2023
karlhorky
reviewed
Apr 13, 2023
karlhorky
reviewed
Apr 13, 2023
"size": "size-limit", | ||
"analyze": "size-limit --why", | ||
"build-docker-ts": "tsc --project docker/tsconfig.build.json", | ||
"postinstall": "patch-package" | ||
}, | ||
"peerDependencies": {}, | ||
"devDependencies": { | ||
"@babel/eslint-parser": "7.21.3", | ||
"@babel/plugin-transform-modules-commonjs": "7.21.2", | ||
"@next/eslint-plugin-next": "13.3.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- probably we can get rid of a lot of these devDependencies as well, especially the ESLint ones
- and you can switch from
@upleveled/eslint-config-upleveled
toeslint-config-upleveled
, which is the new package name
karlhorky
reviewed
Apr 13, 2023
I guess the PR title is not accurate anymore, since it also changes the whole Preflight repo to use pnpm |
ProchaLu
changed the title
Update installation commands to use pnpm
Switch from Yarn to pnpm
Apr 14, 2023
karlhorky
reviewed
Apr 20, 2023
karlhorky
approved these changes
Apr 20, 2023
This was referenced Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #375
Closes: #376
Description
This PR switches Preflight from using Yarn as the package manager to pnpm. The switch to pnpm aims to improve the development workflow and speed up the package installation process.