Add timezone to moving filters on date filter renderers #228
+15
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miexil
requested review from
OwenCoogan and
JulienVannier66
and removed request for
a team
phndiaye
approved these changes
Jan 22, 2025
OwenCoogan
reviewed
Jan 22, 2025
| @@ -28,6 +28,7 @@ export type ColumnDefinition = { | |||
| export type Filter = { | |||
| key: string; | |||
| value: string; | |||
| extra?: any; | |||
There was a problem hiding this comment.
I think {timezone: string } as a type here ?
There was a problem hiding this comment.
pasting linear response here:
Going to reply here, it's an extra field, they are all typed as any throughout the platform because it would be a pain to adapt each different payload everytime.
That being said, this extra payload has just been added to the column filters so that we can pass the timezone payload.
The best I can do, I think, is to change the type to:
extra?: { timezone?: string } | any;
But having that any will mean that pretty much anything will pass and as such the typing is pretty useless 🤷
OwenCoogan
approved these changes
Jan 22, 2025
upfluence-bot
added
reviewed/ready-to-merge
reviewed/needs-work
and removed
reviewed/needs-work
reviewed/ready-to-merge
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add timezone to moving filters on date filter renderers
Good PR checklist