Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose AWS SDK Client Session #246

Merged
merged 1 commit into from
May 22, 2024

Conversation

ulucinar
Copy link
Collaborator

Description

As we are bumping the Terraform provider version to v5.50.0, we have observed that the AWS client session variable has been unexported and we use the session handlers to implement the API call counters in crossplane-contrib/provider-upjet-aws. This PR exports the session variable via an conns.AWSClient.Session function.

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

Copy link
Collaborator

@mergenci mergenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alper 🙏 LGTM. For future reference, we had discussed the issue of disappearing public AWSClient.Session with @mbbush here: crossplane-contrib/provider-upjet-aws#1274 (comment)

@ulucinar ulucinar merged commit de6dd29 into upbound:upjet-v5.50.0 May 22, 2024
23 of 29 checks passed
@ulucinar ulucinar deleted the expose-cli-session branch May 22, 2024 11:17
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants