Add the "Publish Provider Family" workflow to build and push an official provider family #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergenyalcin
approved these changes
Mar 14, 2024
| inputs: | ||
| repository: | ||
| description: 'Official provider family repository to build and publish' | ||
| default: 'crossplane-contrib/provider-upjet-aws' |
There was a problem hiding this comment.
nit: What do you think about making this parameter required and removing the default? For now, we foresee using it only in AWS (since no disk issues have been observed in other providers), but we may also need bigger runners for different providers. Since this workflow is centralized and has release capabilities for any provider, we might consider not having a default for the parameter.
There was a problem hiding this comment.
Done. Moved crossplane-contrib/provider-upjet-aws to the description as an example.
…er family to the Upbound registry using the larger available runners for the upbound Github organization Signed-off-by: Alper Rifat Ulucinar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Although we've observed a successful run of the reusable Publish Service Artifacts workflow here for all the members of the official AWS provider family, that run was from the main branch's HEAD, where the Terraform CLI and the Terraform provider binaries have been removed from the provider packages. But we are still maintaining the
v0.xrelease branches (specificallyv0.47and afterwards) incrossplane-contrib/provider-upjet-awsand thev0.xbranches still bundle those binaries, which increase the disk space requirements during the builds.I anticipate we may not be able to fit a build & publish run with 6 child build jobs for the
v0.xbranch. We had previously tried thepublish-service-artifactsworkflow with 8 child build jobs, and we had observed issues with the Upbound registry as we tried to push 8 (larger) packages in parallel. So I also expect we won't be able to decrease the # of packages we build and push per child job (this would currently mean more child build jobs running in parallel).So, as a backup plan, this PR introduces a new workflow which we can use, in this repository (not as a reusable workflow in the provider family repository), to build and publish the specified provider family. This means that the provider family to be built is a parameter to the newly introduced workflow. Because the workflow is run in this repository, which is under the
upboundGithub organization, we can still enjoy the larger disk space available to oure2-standard-8self-hosted runners.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
A test has succeeded here. And here are the example parameters used for that run:
