Break uptest & crddiff into two separate binaries in preparation of moving uptest under to the Crossplane organization

[ulucinar]

Description of your changes

Currently, the uptest tool and the crddiff tool are implemented as the two commands of a single application, although they have completely different purposes. This was done due to a gap in the build pipelines of this repo. As we would like to move the uptest tool under to the Crossplane organization, it's time to separate them :)

This PR also introduces the Publish Artifacts to GitHub & Promote Artifacts in S3 steps in the publish-artifacts CI job to publish & promote the binary artifacts uptest, crddiff, updoc, ttr, perf and lint-provider-family in the associated S3 bucket.

Breaking Changes:

• The uptest crddiff revision and uptest crddiff self commands are moved to the crddiff application of their own and will be available as crddiff revision & crddiff self commands. uptest e2e command stays the same.

I have:

• Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

The CI steps newly introduced have been tested by exporting the corresponding environment variables:

• AWS_ACCESS_KEY_ID
• AWS_SECRET_ACCESS_KEY
• AWS_DEFAULT_REGION
  and running the publish and a subsequent promote make target.

Also ran the built uptest and crddiff binaries from this PR to check the available sub-commands.

Post merge:

• Successful run of the publish-artifacts CI job has been registered here: https://github.com/upbound/uptest/actions/runs/8079532088/job/22074136600

[sergenyalcin]

Thanks @ulucinar, left a few comments

[sergenyalcin]

nit: It seems that after removing the crddiff subcommands from uptest, we have only the e2e subcommand. What do you think about also removing this subcommand? And using the tool without any subcommand? As I remember correctly, before introducing the crddiff related subcommands, we do not have any subcommands in uptest.

I realize this is a breaking change, but before moving it, we can think in terms of simplification. The question that came to my mind is whether we will need different subcommands in the future.

I'm just writing this as a discussion point; it's not a big deal :)

[ulucinar]

Hi @sergenyalcin,
Thanks for the discussion, very much appreciated.
I've also considered removing the sub-command and decided to keep it with the reasons given in the comment:

• Backwards compatibility: In addition to the official provider repositories, I think this tool is in use in other repositories we don't maintain.
• If we implement some other commands like the preprocess command we've been discussing for a while, it may make sense to add them as sub-commands to uptest as they would be coupled with the e2e tests (preprocessing for the e2e test manifests). If we want to add them as sub-commands, then having e2e as a sub-command makes sense again. If we break it today, then we will probably want to implement such related functionality in separate applications (binaries) in the future.

Considering these two points, I've decided to keep the e2e sub-command. Btw, I think we had the e2e sub-command before crddiff. Please also see this comment.

[sergenyalcin]

Thanks @ulucinar LGTM!