Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding prometheus metrics in stats #65

Merged
merged 3 commits into from
Oct 17, 2022

Conversation

dricoco
Copy link
Contributor

@dricoco dricoco commented Oct 17, 2022

Hello,

We are adding one var in stats template to get the possibility to scrape native haproxy prometheus values.

At the moment this line :

http-request use-service prometheus-exporter if { path /metrics }

cannot be added, so we fix this.

adding the possibility to use http-request in stats to add prometheus exporter on metrics path
@goldyfruit goldyfruit merged commit 3ff0a2c into uoi-io:master Oct 17, 2022
@goldyfruit goldyfruit self-requested a review October 17, 2022 13:12
@goldyfruit
Copy link
Contributor

Thanks for the PR @dricoco

@goldyfruit
Copy link
Contributor

Imported on Galaxy.

image

@denics
Copy link

denics commented Nov 16, 2022

Dear all, can we expect a new release?

@goldyfruit
Copy link
Contributor

The change should be already available in the release on Galaxy, is that the case?

@dricoco
Copy link
Contributor Author

dricoco commented Nov 16, 2022

I think it is, but there is no tag release on github and we are using this instead of galaxy. it probably would make sense to have symmetry between both ?

@goldyfruit
Copy link
Contributor

I think it is, but there is no tag release on github and we are using this instead of galaxy. it probably would make sense to have symmetry between both ?

Done, thanks for the notice 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants