Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Left, Right and Enter behavior for WinForms and WPF #16

Merged
merged 3 commits into from
May 26, 2017

Conversation

Xcone
Copy link

@Xcone Xcone commented May 24, 2017

Hi, as marked in issue #15, I provided some code for left/right behavior. After you explanation to use different SLN's for WPF and Android I also managed to get it working in WPF.

I also changed the enter-key-behavior-during-edit in Winforms. When not editing the setting would work, but during edit it would be forced to the right regardless of setting. In WPF this was already correct.

I couldn't find an editor control in android, and the methods that interact with it all had the comment "not implemented", so I did not bother installing Xamarin and attempt the change for Android as well.

So .. here goes. My first ever Pull request. I hope I did it well.

@jingwood
Copy link
Member

Nice! Thanks!

How about we adding a setting or option for the move behavior during cell edit, e.g.

sheet.EnableSettings(WorksheetSettings.Edit_AllowMoveToNeighborCellDuringEdit);

@jingwood jingwood merged commit 9887aa8 into unvell:develop May 26, 2017
@jingwood jingwood changed the title Left, Right and Enter behavior for WinForms and WPF Left, Right and Enter behavior for WinForms May 26, 2017
@jingwood jingwood changed the title Left, Right and Enter behavior for WinForms Left, Right and Enter behavior for WinForms and WPF May 26, 2017
@jingwood jingwood added this to the ver2.1 milestone May 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants