Fix: Avoid overflow when viewing large files #517
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClickHouse compiles Usearch - with USEARCH_USE_FP16LIB on all platforms - with USEARCH_USE_SIMSIMD on x86 and ARM. I.e. on x86 and ARM, both defines are set. Previously, the code would do the fp32 <--> fp16 conversion using fp16lib but I think it should prefer the "homegrown" conversion routines (SimSIMD).
|
The |
|
Didn't have issues, no need to merge this PR then. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClickHouse compiles Usearch
USEARCH_USE_FP16LIBon all platformsUSEARCH_USE_SIMSIMDon x86 and ARM.I.e. on x86 and ARM, both defines are set. Previously, the code would do
the fp32 <--> fp16 conversion using fp16lib but I think it should prefer
the "homegrown" conversion routines (SimSIMD).