Fix: Fix crash when trying to remove with read-only index #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The index read by view() is read-only. When I did a remove() on that index, it crashed. Although it is an invalid operation to do a remove() on a view() index, it is not a better way to crash, so we have fixed it to return an error.
ashvardanian
approved these changes
Oct 22, 2024
|
Thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The index read by view() is read-only.
When I did a remove() on that index, it crashed. (
Segmentation fault (core dumped))Although it is an invalid operation to do a remove() on a view() index, it is not a better way to crash, so we have fixed it to return an error.