Fix: JavaScript Fix error when searching after load() and view() #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I got an error when I loaded and searched with load() or view().
Code Example:
```js
// Saved with `index.save('index.usearch');` in another script.
index.load('index.usearch');
const results = index.search(new Float32Array([0.2, 0.6, 0.4]), 10);
```
Error:
```
/build/javascript/dist/cjs/usearch.js:314
const result = __classPrivateFieldGet(this, _Index_compiledIndex, "f").search(normalizedVectors, k);
^
TypeError: Search failed
at Index.search (/build/javascript/dist/cjs/usearch.js:314:80)
at Object.<anonymous> (/build/example.js:9:21)
at Module._compile (node:internal/modules/cjs/loader:1469:14)
at Module._extensions..js (node:internal/modules/cjs/loader:1548:10)
at Module.load (node:internal/modules/cjs/loader:1288:32)
at Module._load (node:internal/modules/cjs/loader:1104:12)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:174:12)
at node:internal/main/run_main_module:28:49
Node.js v20.17.0
```
This bug fixed.
|
@abetomo great!! Im suffering the same. |
|
There is a compilation issue on Clang, that needs to be resolved to merge this, @DavidGOrtega & @abetomo. Will do my best to merge tomorrow. Thanks for contributions, guys! |
ashvardanian
requested changes
Oct 10, 2024
|
@abetomo, thank you for being so active, responsive, and ready to operate across languages! It’s great to have you on our side 🤗 |
|
Thanks for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got an error when I loaded and searched with load() or view().
Code Example:
Error:
This bug fixed.