fix: Reset target position and additional attribute on destroy properly

untemps · Oct 6, 2022 · 7e1a75d · 7e1a75d
1 parent 0cd40d2
commit 7e1a75d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/Tooltip.js b/src/Tooltip.js
@@ -128,8 +128,8 @@ class Tooltip {
 	}
 
 	async destroy() {
-		this.#target.setAttribute('style', 'position: null')
-		this.#target.setAttribute('aria-describedby', null)
+		this.#target.style.removeProperty('position')
+		this.#target.removeAttribute('aria-describedby')
 
 		await this.#removeTooltipFromTarget()
 

diff --git a/src/__tests__/useTooltip.test.js b/src/__tests__/useTooltip.test.js
@@ -61,6 +61,8 @@ describe('useTooltip', () => {
 			it('Shows tooltip on mouse enter', async () => {
 				action = useTooltip(target, options)
 				await _enter(target)
+				expect(target).toHaveStyle('position: relative')
+				expect(target).toHaveAttribute('aria-describedby')
 				expect(getElement('#content')).toBeInTheDocument()
 			})
 
@@ -124,7 +126,8 @@ describe('useTooltip', () => {
 		it('Destroys tooltip', async () => {
 			action = useTooltip(target, options)
 			action.destroy(target)
-			expect(target).toHaveStyle('position: null')
+			expect(target).not.toHaveStyle('position: relative')
+			expect(target).not.toHaveAttribute('aria-describedby')
 			await _enter(target)
 			expect(getElement('#content')).not.toBeInTheDocument()
 		})