Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MFW-6331: Timestamp in milliseconds for alerts #479

Merged
merged 2 commits into from
Feb 14, 2025
Merged

MFW-6331: Timestamp in milliseconds for alerts #479

merged 2 commits into from
Feb 14, 2025

Conversation

avinashdige15
Copy link
Contributor

@sumedha-game sumedha-game self-requested a review February 13, 2025 11:57
sumedha-game
sumedha-game previously approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@sumedha-game sumedha-game left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Chinna746
Chinna746 previously approved these changes Feb 13, 2025
View reviewed changes
smitropoulos-arista
smitropoulos-arista requested changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@smitropoulos-arista smitropoulos-arista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use UnixMili instead of a division?

@avinashdige15 avinashdige15 dismissed stale reviews from Chinna746 and sumedha-game via f46c120 February 14, 2025 03:37
@avinashdige15
Copy link
Contributor Author

Why not use UnixMili instead of a division?

Thanks @smitropoulos-arista, I've updated the code now.

@avinashdige15 avinashdige15 changed the title MFW-6331: 13 digit timestamp for alerts MFW-6331: Timestamp in milliseconds for alerts Feb 14, 2025
@avinashdige15 avinashdige15 merged commit 8221cf5 into master Feb 14, 2025
3 checks passed
@avinashdige15 avinashdige15 deleted the MFW-6331 branch February 14, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smitropoulos-arista smitropoulos-arista smitropoulos-arista approved these changes

@vishalmane09 vishalmane09 Awaiting requested review from vishalmane09

@AlistairJohnParker AlistairJohnParker Awaiting requested review from AlistairJohnParker

@sumedha-game sumedha-game Awaiting requested review from sumedha-game

@Chinna746 Chinna746 Awaiting requested review from Chinna746

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@avinashdige15 @AlistairJohnParker @smitropoulos-arista @sumedha-game @Chinna746