Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MFW-5961 Added DnsFilterManager to proto file #455

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

vishalmane09
Copy link
Contributor

@vishalmane09 vishalmane09 commented Dec 23, 2024

  • Did you name your branch and commit in the right format?
  • Did you raise the PR on the correct branch?
  • Did you merge the target branch before creating this PR?
  • Did you add unit tests for your changes
  • Did you create structs instead of using interfaces
  • Did you test your work
  • Did you make sure to DRY your code? Were you able to refactor existing code for reuse instead of making similar code?
  • Did you break your code into smaller methods or components that each have a clear, singular responsibility, and could possibly be reused?
  • Did you reduce the nesting level in your code, so it is not more than three levels nested in a method? Did you return early to reduce nesting?
  • Did you add comments so for instance a new developer would understand this code, and understand any business logic?
  • Did you add an intranet note/page if this is new behavior/feature
  • Did you resolve all conversations on the PR?

@vishalmane09 vishalmane09 self-assigned this Dec 23, 2024
Copy link
Contributor

@vishal-malji vishal-malji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vishalmane09 vishalmane09 merged commit 7fcdf72 into mfw-release-6.1 Jan 6, 2025
2 checks passed
@vishalmane09 vishalmane09 deleted the MFW-5961 branch January 6, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants