-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore slashes after the protocol for special URLs #208
Conversation
I have to add tests but it should work. |
LGTM when additional tests are added. |
04db85c
to
320a8dc
Compare
In addition to #208 (comment) and #208 (comment) there are a lot of other inconsistencies with the Node.js WHATWG URL parser. I don't think it's possible to fix all of them without adding a lot of complexity. It is probably easier to rewrite |
Set it to `true` only if the protocol is special or if it is actually followed by two forward slashes.
If the value of the `pathname` property does not start with a `/`, add it only if the URL is special.
@3rd-Eden I'm merging this. Can you please cut a new release? |
Fixes #205
Fixes #206