[fix] Threat single forward/barckward slashes as double slashes extracting protocols #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpinca
reviewed
Jul 23, 2021
| , protocol = match[1] ? match[1].toLowerCase() : '' | ||
| , slashes = !!(match[2] && match[2].length >= 2) | ||
| , rest = match[2] && match[2].length === 1 ? '/' + match[3] : match[3]; | ||
| , slashes = protocol && slash || !!(slash && match[2].length >= 2) |
There was a problem hiding this comment.
It fails for parse('foo:/bar'). That should return '/bar' as pathaname and not 'bar' as host.
There was a problem hiding this comment.
Interestingly we don't have a test case for that, that will complicate things a lot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title, this ensures that
http:/whatever.comandhttp:\whatever.comare both normalized tohttp://protocols. This allows the correct hostname and paths to be extracted from these invalid URL'sFixes #206