Style entities decoder #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unreal4u
requested changes
Jan 21, 2022
There was a problem hiding this comment.
hi!
Thanks for submitting this PR!
While I am a bit reticent to add methods to a Type (which comes from Telegram themselves) I understand there is no other place where we could do this type of stuff and there would need to be some major refactoring in order for us to be able to do this in any other way.
Can you pick up the comments I left so that I can approve it? Thanks!
|
Hi, |
|
Sorry it took so long @LucaDevelop but I didn't receive ANY notification of your changes! Just happened to stumble across it now and saw that you submitted all changes, I'll review my notification settings so it doesn't happen again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I've created this class to read the text (or the caption) and the entities from message object and return the text with inline entities (HTML, MarkdownV2 or Markdown) that replicate the original styles but with the possibility to manipulate it afterwards.
I've used it in several bots of mine alongside your library and I've decide to add it directly in the Message class.
This is the repo of my class: https://github.com/LucaDevelop/telegram-entities-decoder
I hope it can be useful.