Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic error messages from API response #136

Closed
DJTommek opened this issue Aug 9, 2021 · 0 comments · Fixed by #137
Closed

Generic error messages from API response #136

DJTommek opened this issue Aug 9, 2021 · 0 comments · Fixed by #137

Comments

@DJTommek
Copy link
Contributor

DJTommek commented Aug 9, 2021

Which version are you using?

New behavior: current master (revision e4fdf5f)
Old behavior: revision 3436f3b
PHP version doesn't matter, tested with 7.2.33, 7.3.21, 7.4.9 and 8.0.9

Description of problem

It seems, that after PR #127 which migrates reactphp, there is no longer access to real error message from Telegram, but generic HTTP 400 error is returned instead.

Steps to reproduce incorrect behavior:

  1. clone repo and open terminal in cloned folder
  2. run composer install
  3. update BOT_TOKEN constant in examples/conf.php
  4. run php examples/get-chat-members-count.php

Description of error message: "HTTP status code 400 (Bad Request)"

Steps to reproduce old correct behavior:

  1. clone repo but checkout to 3436f3b revision (just before Migrate reactphp/http-client to reactphp/client #127), then continue as usually

Description of error message: "Bad Request: chat not found"

Added attachments of Tracy logging which is interactive, so you can check all parameters across call stack or environment.

Because Github is not allowing updating HTML files, I uploaded them as .txt. Just rename them as .html and open in browser.

ping @Yoshi2889

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant